extend_mode_normalized and extend_mode
#974
Conversation
|
It works on my local ubuntu machine but not in CI. Is this the case for |
|
The windows failure certainly would be caused by the lack of GPU support for those runners. I'm not sure what the ubuntu failure is. Unfortunately, #892 means that the "current version" uploading of the snapshots is currently broken. I'll open a PR to fix that today. |
|
And if you can rebase #1018, that would make debugging the failure on ubuntu more plausible to debug |
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
|
rebased! |
|
I'm assuming that the failure on Ubuntu is because we're using a fallback CPU implementation of Vulkan, and therefore the precision is too high. What isn't at all clear to me is why the similar test from #971 passed on that version. I think just marking the new tests as |
Signed-off-by: sagudev <[email protected]>
because CI uses SW which is more accurate then real GPUs Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Current
extend_modeis renamed toextend_mode_normalized(because it require normalized coordinates). To avoid rounding errors we introduceextend_modethat relaxes normalization requirement. Currently only EXTEND_PAD is implemented differently, others fallback toextend_mode_normalizedfor now.partial fix #972